[#76] Moved functionality from Artifact class to ArtifactCommand class. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 22.87% 32.21% +9.34%
==========================================
Files 7 6 -1
Lines 529 537 +8
==========================================
+ Hits 121 173 +52
+ Misses 408 364 -44 ☔ View full report in Codecov by Sentry. |
AlexSkrypnyk
requested changes
Mar 19, 2024
src/app.php
Outdated
|
|
||
| $application = new Application(); | ||
|
|
||
| $command = new ArtifactCommand(); | ||
| $git = new GitArtifactGit(); |
There was a problem hiding this comment.
please move this into the ArtifactCommand class
please do not modify this file - it is a standard entrypoint
There was a problem hiding this comment.
Hi @AlexSkrypnyk
I have reverted to standard entry point.
AlexSkrypnyk
approved these changes
Mar 19, 2024
AlexSkrypnyk
deleted the
feature/move-artifact-class-to-artifact-command-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
closes #76
[#123] Verb in past tense with dot at the end.Changedsection about WHY something was done if this was not a normal implementationChanged
Screenshots